Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions apps/trigger/serializers/trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,10 +128,10 @@ def _validate_required_field(setting, field_name, trigger_type):
def _validate_non_empty_array(value, field_name):
if not isinstance(value, list):
raise serializers.ValidationError({
'trigger_setting': _('%s must be an array') % field_name })
'trigger_setting': _('%s must be an array') % field_name})
if len(value) == 0:
raise serializers.ValidationError({
'trigger_setting': _('%s must not be empty') % field_name })
'trigger_setting': _('%s must not be empty') % field_name})

@staticmethod
def _validate_number_range(values, field_name, min_val, max_val):
Expand Down Expand Up @@ -166,8 +166,9 @@ def _validate_scheduled_setting(self, setting):

valid_types = ['daily', 'weekly', 'monthly', 'interval']
if schedule_type not in valid_types:
raise serializers.ValidationError({ 'trigger_setting': _('schedule_type must be one of %s') % ', '.join(valid_types)
})
raise serializers.ValidationError(
{'trigger_setting': _('schedule_type must be one of %s') % ', '.join(valid_types)
})
if schedule_type == 'daily':
self._validate_daily(setting)
elif schedule_type == 'weekly':
Expand Down