Closed
Conversation
… error check and comments
Pull Request Test Coverage Report for Build 14490060666Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a test file for the packages/data/load.py file.
During this process I discovered that passing non Paths or Strings to the stream parameter did not raise an error. So I have added one. I also added comments to the original code file to explain what each line does as I did this to understand how the script processes input data for testing. I also reformatted the stream list index selection to be more readable.
All tests pass when running now. I also tested running some of the tutorial notebooks to check for change in behaviour.