Tests and updates added for data/load.py#101
Merged
tennlee merged 5 commits intoACCESS-Community-Hub:developfrom Apr 17, 2025
Merged
Tests and updates added for data/load.py#101tennlee merged 5 commits intoACCESS-Community-Hub:developfrom
tennlee merged 5 commits intoACCESS-Community-Hub:developfrom
Conversation
Tests and updates for packages/data/load.py
Pull Request Test Coverage Report for Build 14513344028Details
💛 - Coveralls |
Collaborator
|
Looks great! pre-commit is still complaining a little. I'll tidy it up post-merge, but we should catch up next week and check why there's an inconsistency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a tests file for the data.load.py file.
During testing I found the original file doesn't raise errors when passing incorrect data types so I added an error check for this.
I also added comments to the original code file as these helped me test its functionality and understand the purpose of the code and I thought they would be useful for others. I also reformated the list indexing syntax to be more conventional.
All tests were passing and I tested by running some of the tutorial notebooks to check for changes in behaviour.