Skip to content

Comments

Tests and updates added for data/load.py#101

Merged
tennlee merged 5 commits intoACCESS-Community-Hub:developfrom
JMP-MO:develop
Apr 17, 2025
Merged

Tests and updates added for data/load.py#101
tennlee merged 5 commits intoACCESS-Community-Hub:developfrom
JMP-MO:develop

Conversation

@JMP-MO
Copy link
Collaborator

@JMP-MO JMP-MO commented Apr 16, 2025

Added a tests file for the data.load.py file.

During testing I found the original file doesn't raise errors when passing incorrect data types so I added an error check for this.
I also added comments to the original code file as these helped me test its functionality and understand the purpose of the code and I thought they would be useful for others. I also reformated the list indexing syntax to be more conventional.

All tests were passing and I tested by running some of the tutorial notebooks to check for changes in behaviour.

@coveralls
Copy link

coveralls commented Apr 16, 2025

Pull Request Test Coverage Report for Build 14513344028

Details

  • 43 of 43 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 58.806%

Totals Coverage Status
Change from base Build 14513314052: 0.2%
Covered Lines: 7919
Relevant Lines: 13098

💛 - Coveralls

@tennlee
Copy link
Collaborator

tennlee commented Apr 17, 2025

Looks great! pre-commit is still complaining a little. I'll tidy it up post-merge, but we should catch up next week and check why there's an inconsistency.

@tennlee tennlee merged commit 7baf551 into ACCESS-Community-Hub:develop Apr 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants