rename Squish to Squeeze#105
Merged
tennlee merged 1 commit intoACCESS-Community-Hub:developfrom Apr 30, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 14745973408Details
💛 - Coveralls |
Collaborator
|
The coding looks great at a glance. I will proceed to running some of the notebooks and checking the automated test coverage shortly. |
Collaborator
|
It's a shame these files don't have pre-existing test coverage. I tried executing the squeeze in a notebook, but it failed for reasons that appear unrelated to your change. The rename itself caused no issues. So I think the PR is okay, but I look forward to getting some test coverage around these files in due course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed "Squish" to "Squeeze" in:
One minor note: I hope I haven't messed anything up with the notebooks. I think I was only changing references to that one function, but let me know if the act of opening them in my own JupyterLab has altered something that I need to put back.