Skip to content

Comments

rename Squish to Squeeze#105

Merged
tennlee merged 1 commit intoACCESS-Community-Hub:developfrom
gemmaellen:rename_squish
Apr 30, 2025
Merged

rename Squish to Squeeze#105
tennlee merged 1 commit intoACCESS-Community-Hub:developfrom
gemmaellen:rename_squish

Conversation

@gemmaellen
Copy link
Collaborator

Renamed "Squish" to "Squeeze" in:

  • both pipeline/operations/dask and pipeline/operations/numpy
  • tutorial notebooks
  • old documentation

One minor note: I hope I haven't messed anything up with the notebooks. I think I was only changing references to that one function, but let me know if the act of opening them in my own JupyterLab has altered something that I need to put back.

@gemmaellen gemmaellen requested a review from tennlee April 30, 2025 03:20
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14745973408

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 61.17%

Totals Coverage Status
Change from base Build 14731756411: 0.0%
Covered Lines: 8371
Relevant Lines: 13335

💛 - Coveralls

@tennlee
Copy link
Collaborator

tennlee commented Apr 30, 2025

The coding looks great at a glance. I will proceed to running some of the notebooks and checking the automated test coverage shortly.

@tennlee
Copy link
Collaborator

tennlee commented Apr 30, 2025

It's a shame these files don't have pre-existing test coverage. I tried executing the squeeze in a notebook, but it failed for reasons that appear unrelated to your change. The rename itself caused no issues. So I think the PR is okay, but I look forward to getting some test coverage around these files in due course.

@tennlee tennlee merged commit 5366d75 into ACCESS-Community-Hub:develop Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants