tests for numpy reshape (+bugfixes)#112
tests for numpy reshape (+bugfixes)#112tennlee merged 14 commits intoACCESS-Community-Hub:developfrom
Conversation
Pull Request Test Coverage Report for Build 15183996552Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Thanks. I applied the black formatter to fix the pre-commit check. I agree with your changes but will leave the commented-out lines in the file for now in case they prove helpful. To my eyes they look "overly helpful" and are handling some shape mismatch condition that may have been encountered but is not covered by our tests or current notebooks / examples in manual testing. I will re-run the notebooks at some point after this and confirm nothing breaks there. If needed, the commented-out lines are easily restored. Thank you very much for putting in good tests to cover this important area of functionality! |
Hey! I've written tests for numpy/reshape.py. Most of them are straightforward, but there are a couple of things that are worth reviewing. Specifically, in numpy/reshape.py, I want to note that:
data[-len(shape)]isn't usually an integer anyway. It's possible that it should bedata.shape[-len(shape)]but even then I'm not sure why you'd want it.I'd appreciate a check that my fixes haven't accidentally broken something, but I think this is probably closer to what we want the code to be.