Tests, bugfixes and improved docstring for Flatten in data/transforms/coordinates.py#148
Merged
tennlee merged 6 commits intoACCESS-Community-Hub:developfrom Jul 29, 2025
Conversation
Collaborator
|
It's so great to have a good docstring on this functionality and also the bugfix. I need to get back in and tidy up the code linting, so I might do that tomorrow along with merging the PR, but this looks really useful. How does Flatten relate to CoordinateFlatten, and do we need both of them? |
Pull Request Test Coverage Report for Build 16590418143Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted on a recent call, the Flatten class had a confusing docstring and a bug in need of fixing. These have been improved, and I have added some tests for the class as a whole.