Add tests for split pipeline operations #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The join fix is needed since the split onslice must keep the dimension that it was split on e.g. if splitting from (2, 3) into (2, 1), and (2, 2), the second dim must be kept and the join should join again on that second dim. Before, it was trying to join by creating a new dim
Fixes hsplit and vsplit calls as they require an indices_or_sections argument. The value chosen is such that the number of arrays returned is equal to the number of elements in the 0th and 1st dimensions for vsplit and hsplit, respectively.
Also includes fix for the join method since xr.merge would fail due to incompatible coords after splitting.
Like numpy, concat is required to reverse the split.
Pull Request Test Coverage Report for Build 20839996018Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes some issues with the join methods as they would fail to reverse the original split method.