Testing for default normalisation#67
Merged
tennlee merged 5 commits intoACCESS-Community-Hub:developfrom Mar 26, 2025
Merged
Conversation
Start adding a little test coverage
Pull Request Test Coverage Report for Build 14083275211Details
💛 - Coveralls |
Collaborator
Author
|
Coverage lifted from around 20% to 44%, but this is a useful increment and I suggest it could be merged here. Remaining coverage will require more complex test data construction and/or more complex mocking to achieve. |
Collaborator
Author
|
Merging this to get the bug resolved and improve coverage. Please feel free to raise new issues should there be further work required. |
Collaborator
|
Hi @tennlee, would it be ok to run |
Collaborator
Author
|
I have just re-run the black and end-of-line formatters, things should be happy again. I will try to help with the isort issues if I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test coverage is not yet great, but this PR contains a useful change in that the case of the Normalisation class has been corrected. There would be some value in merging this now and raising a new PR for further expanding test coverage, but it is also reasonable to wait while more coverage is added to this PR. It also contains an actual bugfix where part of the code is calling a lower-case "drop" when an upper-case "Drop" is required. Putting up the PR now so that if anyone runs into these issues, they can request an early merge.