Skip to content

Comments

Refactor/simplify test paths for data, training & utils#94

Merged
tennlee merged 4 commits intoACCESS-Community-Hub:developfrom
millerjoel:refactor/simplify-test-paths
Apr 7, 2025
Merged

Refactor/simplify test paths for data, training & utils#94
tennlee merged 4 commits intoACCESS-Community-Hub:developfrom
millerjoel:refactor/simplify-test-paths

Conversation

@millerjoel
Copy link
Collaborator

I've removed redundant path components to the tests for the data, training & utils packages. The pipeline package already had a suitable structure and tutorial package has no tests yet. All packages now follow the same structure.

The new structure, using utils for example, is:
/packages/utils/tests/*

The old structure was:
/packages/utils/tests/pyearthtools/utils/*

@tennlee Please can you check the structure I have gone with before merging? I think you had a slightly different suggestion in a comment you made in issue #36, although I'm wondering if it was a typing error. Perhaps I should have been even more ruthless with what I removed from the path?

@millerjoel millerjoel requested a review from tennlee April 7, 2025 14:49
@coveralls
Copy link

coveralls commented Apr 7, 2025

Pull Request Test Coverage Report for Build 14321333946

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.605%

Totals Coverage Status
Change from base Build 14321327612: 0.0%
Covered Lines: 7867
Relevant Lines: 13054

💛 - Coveralls

@tennlee
Copy link
Collaborator

tennlee commented Apr 7, 2025

The PR looks good. It looks like there some issues with the black reformatting. I suspect you may need to update the version of black in your environment. To keep things moving, I'll go ahead and merge the PR and then reformat those files subsequently.

@tennlee tennlee merged commit 00f59f3 into ACCESS-Community-Hub:develop Apr 7, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants