Refactor/simplify test paths for data, training & utils#94
Merged
tennlee merged 4 commits intoACCESS-Community-Hub:developfrom Apr 7, 2025
Merged
Conversation
Pull Request Test Coverage Report for Build 14321333946Details
💛 - Coveralls |
Collaborator
|
The PR looks good. It looks like there some issues with the black reformatting. I suspect you may need to update the version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've removed redundant path components to the tests for the data, training & utils packages. The pipeline package already had a suitable structure and tutorial package has no tests yet. All packages now follow the same structure.
The new structure, using utils for example, is:
/packages/utils/tests/*
The old structure was:
/packages/utils/tests/pyearthtools/utils/*
@tennlee Please can you check the structure I have gone with before merging? I think you had a slightly different suggestion in a comment you made in issue #36, although I'm wondering if it was a typing error. Perhaps I should have been even more ruthless with what I removed from the path?