Improvements and fixes for #3217 #3229
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We update codecs to use `case class` instead of `case object`, like we do for the similar `require_confirmed_inputs` TLV, which lets us use the helper functions on TLV streams and provide better consistency. We add documentation to the acountability TLV fields. We also simplify the trait hierarchy in `PaymentOnion.scala` by removing unnecessary additions.
We refactor the following parts of the payment flow: - when fetching confidence score, the downstream node is always known, we don't need to use an `Option` in `GetConfidence` - we remove the restrictions that require accountability for on-the-fly funding, we don't want to negatively impact wallets yet - we never fail HTLCs based on accountability / incoming confidence, we only log that we would have failed them to collect data, it's way too early to actually enforce any of those restrictions - we reorder the `accountability` parameter in various functions, to make it appear before optional, less important parameters (for example custom TLVs) - we revert a bunch of small, unnecessary changes to minimize the diff with `master` We also add documentation and comments to help readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits on top of #3217 to fix my comments made on that PR:
case classinstead of acase objectand clean-up a few placesmasterMore details in each commit message.