Correct fp4 tensor size calculation #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new utility will use jnp.finfo and jnp.iinfo to determine the accurate bit width of any dtype, ensuring correct bandwidth metrics for current and future sub-byte types (like int4 or float4).
Collaborator
|
Did you test your change? Can you share the new test collective test results for FP4? Otherwise, LGTM. |
Collaborator
Author
Yes, the result for all gather on 2x2x2 is as followed:
|
linamy85
added a commit
that referenced
this pull request
Feb 5, 2026
The new utility will use jnp.finfo and jnp.iinfo to determine the accurate bit width of any dtype, ensuring correct bandwidth metrics for current and future sub-byte types (like int4 or float4).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new utility will use jnp.finfo and jnp.iinfo to determine the accurate bit width of any dtype, ensuring correct bandwidth metrics for current and future sub-byte types (like int4 or float4).