Skip to content

Comments

Integrate MaxText CI with Codecov#2864

Merged
copybara-service[bot] merged 1 commit intomainfrom
codecov
Dec 22, 2025
Merged

Integrate MaxText CI with Codecov#2864
copybara-service[bot] merged 1 commit intomainfrom
codecov

Conversation

@shralex
Copy link
Collaborator

@shralex shralex commented Dec 21, 2025

Integrates code coverage (Codecov) in MaxText. The complexity of doing so stems from the fact that we don't always run the same set of tests -- PRs run a subset of tests, while tests marked as scheduled_only are executed only on scheduled runs. In this PR we use a two-flag scheme (regular, scheduled) and carryforward logic to accurately track coverage.

This PR adds codecov.yml to enable carryforward for tests skipped in PRs (scheduled_only). Updates test workflows to generate coverage reports via pytest-cov and upload results with conditional flags. We also set Project coverage to track the full scheduled baseline and Patch coverage to evaluate new code against regular PR tests. A 5% regression in coverage will fail a PR or test run.

Tests

Testing in CI.

Checklist

Before submitting this PR, please make sure (put X in square brackets):

  • I have performed a self-review of my code. For an optional AI review, add the gemini-review label.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have run end-to-end tests tests and provided workload links above if applicable.
  • I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in our documentation.

Copy link
Collaborator

@richjames0 richjames0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Integrates Codecov using a two-flag scheme (regular, scheduled) and carryforward logic to accurately track coverage across tiered test suites.

Adds codecov.yml to enable carryforward for tests skipped in PRs (scheduled_only).
Updates test workflows to generate coverage reports via pytest-cov and upload results with conditional flags.
Sets Project coverage to track the full scheduled baseline and Patch coverage to evaluate new code against regular PR tests.
@copybara-service copybara-service bot merged commit 56a7fd8 into main Dec 22, 2025
24 of 27 checks passed
@copybara-service copybara-service bot deleted the codecov branch December 22, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants