Conversation
364cf4e to
cdba187
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
khatwanimohit
commented
Jan 8, 2026
khatwanimohit
commented
Jan 8, 2026
Collaborator
Author
khatwanimohit
left a comment
There was a problem hiding this comment.
Add train_compile tests for Diloco
NuojCheng
reviewed
Jan 8, 2026
NuojCheng
reviewed
Jan 8, 2026
NuojCheng
reviewed
Jan 8, 2026
NuojCheng
reviewed
Jan 8, 2026
NuojCheng
reviewed
Jan 8, 2026
NuojCheng
reviewed
Jan 8, 2026
c607a2a to
b522696
Compare
e32bf73 to
6d53cca
Compare
|
🤖 Hi @khatwanimohit, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
There was a problem hiding this comment.
📋 Review Summary
This Pull Request introduces DiLoCo (Distributed Low-Communication) training to MaxText, along with necessary configuration parameters, code modifications for sharding and training loop, and unit tests. The implementation seems comprehensive and well-integrated.
🔍 General Feedback
- The core logic for DiLoCo training is encapsulated in the new
diloco.pymodule, which improves modularity. - The unit tests provided in
diloco_test.pycover basic functionality and mesh configurations, which is good for verifying the new feature. - The addition of
drjaxas a dependency is appropriate given the DiLoCo implementation.
6d53cca to
0d4e69c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces support for Distributed Low-Communication (DiLoCo) training in MaxText. It implements both standard DiLoCo, enabling efficient model training across disjoint clusters ("islands") by synchronizing gradients infrequently via an outer optimizer.
Key Changes
and communication synchronization using drjax.
step when enable_diloco is active. This includes handling data reshaping for multiple replicas.
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.