Draft
Conversation
17bc93f to
1738b3e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Background: A previous PR upgrading google-cloud-mldiagnostics through seed-env resulted in dependency issues caused by (1)
cloud-tpu-diagnosticsversion1.1.14being yanked but dependency resolver unable to detect and exclude this (b/477743392) and (2) TPU lock file unable to pick up versiongoogle-cloud-mldiagnostics 0.5.10. This PR also inadvertently removedjaraco-functools, causing some more CI failures and was rolled back.This change is attempting do a full update of both TPU and GPU deps.
FIXES: b/481140947
Tests
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.