Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Qwen3 1.7B model configs. It's extremely similar to other Qwen model configs, with slight changes to the base_emb_dim and base_mlp_dim relative to the 0.6B. I've made a slight change to the documentation listing 1.7B as a supported model.
Tests
I tested this on a Google Colab v6e1 instance, via the provided Qwen SFT demo notebook. The training cell with TFLOPs and loss succeeded, so I'm pretty confident the architecture mapping and parameter conversion was done properly. To reproduce, all I changed was the notebook to use 1.7B instead of the 0.6B model. However, I wasn't able to run the cells regarding vLLM, due to a ipython issue.
vLLM Error
Logs
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.