PR #3044: move src/MaxText/configs to src/maxtext/configs#3107
Closed
copybara-service[bot] wants to merge 1 commit intomainfrom
Closed
PR #3044: move src/MaxText/configs to src/maxtext/configs#3107copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
requested review from
A9isha,
Lumosis,
NicoGrande,
NuojCheng,
Obliviour,
RissyRan,
SujeethJinesh,
SurbhiJainUSC,
aireenmei,
bvandermoon,
gagika,
gobbleturk,
gpolovets1,
hengtaoguo,
jacoguzo,
jesselu-google,
jiangjy1982,
jrplatin,
khatwanimohit,
mailvijayasingh,
mitalisi,
notabee,
parambole,
patemotter,
richjames0,
shauryagup,
shralex,
shuningjin,
suexu1025 and
vipannalla
as code owners
copybara-service
bot
force-pushed
the
test_866611198
branch
9 times, most recently
from
aca9540 to
6a4e89d
Compare
Imported from GitHub PR #3044 # Description move src/MaxText/configs to src/maxtext/configs New structure of config files ``` configs/ ├── gpu/ │ ├── a3/ # from configs/a3/ │ │ ├── llama_2_7b/ │ │ └── llama_3.1_405b/ │ └── models/ # from configs/models/gpu/ │ ├── llama2_70b.yml │ ├── llama2_7b.yml │ └── ... ├── inference/ │ ├── multihost/ # from inference/configs/multi_host/ │ │ ├── disaggregation/ │ │ │ └── llama3_405b_v6e-16-16.yml │ │ └── interleaved/ │ │ ├── llama2_70b_v5e-16.yml │ │ ├── llama3_405b_v5e-64.yml │ │ └── llama3_70b_v5e-16.yml │ ├── inference.yml # from configs/inference.yml │ └── inference_jetstream.yml # from configs/inference_jetstream.yml ├── post_train/ │ ├── distillation.yml # from configs/distillation.yml │ ├── dpo.yml # from configs/dpo.yml │ ├── rl.yml # from configs/rl.yml │ ├── rl_mt_jt.yml # from configs/rl_mt_jt.yml │ ├── sft.yml # from configs/sft.yml │ ├── sft-vision-chartqa.yml # from configs/sft-vision-chartqa.yml │ └── sft-vision-slidevqa.yml # from configs/sft-vision-slidevqa.yml ├── tpu/ │ ├── v4/ # from configs/v4/ │ ├── v5e/ # from configs/v5e/ │ ├── v5p/ # from configs/v5p/ │ └── v6e/ # from configs/v6e/ + configs/trillium/ ├── models/ # stays in place (configs/models/) │ ├── deepseek2-16b.yml │ ├── llama2-7b.yml │ └── ... # (gpu/ subfolder removed, moved to gpu/models/) ├── experimental/ # stays in place ├── quantization/ # stays in place ├── __init__.py ├── types.py ├── base.yml ├── decoupled_base_test.yml ├── gpu_smoke_test.yml ├── tpu_smoke_test.yml ├── vllm.yml └── README.md ``` *Notice 1:* Once all tests pass, the "pull ready" label will automatically be assigned. This label is used for administrative purposes. Please do not add it manually. *Notice 2:* For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests. # Tests Github CI # Checklist Before submitting this PR, please make sure (put X in square brackets): - [x] I have performed a self-review of my code. For an optional AI review, add the `gemini-review` label. - [x] I have necessary comments in my code, particularly in hard-to-understand areas. - [x] I have run end-to-end tests tests and provided workload links above if applicable. - [x] I have made or will make corresponding changes to the doc if needed, including adding new documentation pages to the relevant Table of Contents (toctree directive) as explained in [our documentation](https://maxtext.readthedocs.io/en/latest/development.html#adding-new-documentation-files). Copybara import of the project: -- e2e63f1 by Mohit Khatwani <mohitkhatwani@google.com>: move src/configs to src/maxtext/configs Merging this change closes #3044 PiperOrigin-RevId: 866611198
copybara-service
bot
force-pushed
the
test_866611198
branch
from
6a4e89d to
bd4e3c4
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3044: move src/MaxText/configs to src/maxtext/configs
Imported from GitHub PR #3044
Description
move src/MaxText/configs to src/maxtext/configs
New structure of config files
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Github CI
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.Copybara import of the project:
--
e2e63f1 by Mohit Khatwani mohitkhatwani@google.com:
move src/configs to src/maxtext/configs
Merging this change closes #3044