Skip to content

🐛 filesystem Unlink files before attempting to remove them in Remove #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshjennings98 merged 4 commits into from
Aug 1, 2025
+23 −4
Merged

🐛 filesystem Unlink files before attempting to remove them in Remove #664

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
361451e
:bug: `filsystem` Unlink files before attempting to remove them in Re…
joshjennings98 Aug 1, 2025
2c87cb7
ignore is a directory error in unlink
joshjennings98 Aug 1, 2025
a11986c
:sparkles: `commonerrors` Add IgnoreCorrespondTo function
joshjennings98 Aug 1, 2025
d99c469
Update utils/commonerrors/errors.go
acabarbaye Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/20250801093542.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:bug: `filsystem` Unlink files before attempting to remove them in Remove
9 changes: 5 additions & 4 deletions utils/filesystem/extendedosfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,14 @@ type ExtendedOsFs struct {
}

func (c *ExtendedOsFs) Remove(name string) (err error) {
err = commonerrors.Ignore(ConvertFileSystemError(c.OsFs.Remove(name)), commonerrors.ErrNotFound)
if err != nil {
return
}
// The following is to ensure sockets are correctly removed
// https://stackoverflow.com/questions/16681944/how-to-reliably-unlink-a-unix-domain-socket-in-go-programming-language
err = commonerrors.Ignore(ConvertFileSystemError(syscall.Unlink(name)), commonerrors.ErrNotFound)
if err != nil {
return
}

err = commonerrors.Ignore(ConvertFileSystemError(c.OsFs.Remove(name)), commonerrors.ErrNotFound)
return
}

Expand Down
Loading