✨ [parallelisation] Extend the cancel/close store to have various ways of functioning (e.g. parallel, sequential, reverse order, etc.)
#676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ays of functioning (e.g. parallel, sequential, reverse order, etc.)
aorabdel
reviewed
Aug 13, 2025
Comment on lines
+28
to
+31
| option := ExecuteAll | ||
| if stopOnFirstError { | ||
| option = StopOnFirstError | ||
| } |
Contributor
There was a problem hiding this comment.
Having an option only represent a positive will help us avoid overwriting options which will simplify option interactions if things get complicated, what do you think?
Contributor
Author
There was a problem hiding this comment.
the overwriting is because the stores cancel and close have fundamentally different behaviours
| } | ||
| } | ||
|
|
||
| // NewCloseFunctionStoreStore is exactly the same as NewConcurrentCloseFunctionStore but without a typo in the name. |
Contributor
Author
There was a problem hiding this comment.
StoreStore in the name
aorabdel
previously approved these changes
Aug 13, 2025
acabarbaye
commented
Aug 13, 2025
acabarbaye
commented
Aug 13, 2025
acabarbaye
commented
Aug 13, 2025
acabarbaye
commented
Aug 13, 2025
acabarbaye
commented
Aug 13, 2025
Co-authored-by: Abdelrahman Abdelraouf <abdelrahman.abdelraouf@arm.com>
aorabdel
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend the stores so it can be executed differently : i.e. sequentially vs concurrently
Test Coverage