Skip to content

🐛 subprocess Make sure that newSubProcess supports overriding the stdin, stdout, and stderr #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acabarbaye merged 2 commits into from
Sep 11, 2025
Merged

🐛 subprocess Make sure that newSubProcess supports overriding the stdin, stdout, and stderr #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70fb074
:bug: `subprocess` Make sure that newSubProcess supports overriding t…
joshjennings98 Sep 11, 2025
79fe448
Merge branch 'master' into excecute-stdout-etc-fix
joshjennings98 Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/20250911152014.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:bug: `subprocess` Make sure that newSubProcess supports overriding the stdin, stdout, and stderr
2 changes: 1 addition & 1 deletion utils/subprocess/executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func NewWithEnvironmentWithIO(ctx context.Context, loggers logs.Loggers, io ICom
// newSubProcess creates a subprocess description with custom IO
func newSubProcess(ctx context.Context, loggers logs.Loggers, io ICommandIO, env []string, messageOnStart string, messageOnSuccess, messageOnFailure string, as *commandUtils.CommandAsDifferentUser, cmd string, args ...string) (p *Subprocess, err error) {
p = new(Subprocess)
err = p.SetupAsWithEnvironment(ctx, loggers, env, messageOnStart, messageOnSuccess, messageOnFailure, as, cmd, args...)
err = p.SetupAsWithEnvironmentWithCustomIO(ctx, loggers, io, env, messageOnStart, messageOnSuccess, messageOnFailure, as, cmd, args...)
return
}

Expand Down
Loading