Skip to content

✨ [headers] Support headers for verb tunnelling #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acabarbaye merged 1 commit into from
Oct 7, 2025
Merged

✨ [headers] Support headers for verb tunnelling #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/20251006152230.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
:sparkles: `[headers]` Support headers for [verb tunnelling](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-odata/bdbabfa6-8c4a-4741-85a9-8d93ffd66c41)
23 changes: 17 additions & 6 deletions utils/http/headers/headers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,19 @@ const (
HeaderDeprecation = "Deprecation" // https://datatracker.ietf.org/doc/html/draft-ietf-httpapi-deprecation-header-02
HeaderLink = headers.Link // https://datatracker.ietf.org/doc/html/rfc8288
// TUS Headers https://tus.io/protocols/resumable-upload#headers
HeaderUploadOffset = "Upload-Offset"
HeaderTusVersion = "Tus-Version"
HeaderUploadLength = "Upload-Length"
HeaderTusResumable = "Tus-Resumable"
HeaderTusExtension = "Tus-Extension"
HeaderTusMaxSize = "Tus-Max-Size"
HeaderUploadOffset = "Upload-Offset"
HeaderTusVersion = "Tus-Version"
HeaderUploadLength = "Upload-Length"
HeaderTusResumable = "Tus-Resumable"
HeaderTusExtension = "Tus-Extension"
HeaderTusMaxSize = "Tus-Max-Size"
// Verb tunnelling (see https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-odata/bdbabfa6-8c4a-4741-85a9-8d93ffd66c41)
// CAUTION see the security risk of supporting such headers https://www.sidechannel.blog/en/http-method-override-what-it-is-and-how-a-pentester-can-use-it/
HeaderXHTTPMethodOverride = "X-HTTP-Method-Override"
HeaderXHTTPMethod = "X-HTTP-Method"
HeaderXMethodOverride = "X-Method-Override"
HeaderXOverrideMethod = "X-Override-Method"

// TUS extensions Headers
HeaderUploadMetadata = "Upload-Metadata" // See https://tus.io/protocols/resumable-upload#upload-metadata
HeaderUploadDeferLength = "Upload-Defer-Length" // See https://tus.io/protocols/resumable-upload#upload-defer-length
Expand All @@ -51,6 +57,8 @@ const (
)

var (
// VerbTunnellingHeaders defines the non-standard headers which can be used for Verb tunnelling (see https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-odata/bdbabfa6-8c4a-4741-85a9-8d93ffd66c41)
VerbTunnellingHeaders = []string{HeaderXHTTPMethodOverride, HeaderXHTTPMethod, HeaderXMethodOverride, HeaderXOverrideMethod}
// SafeHeaders corresponds to headers which do not store personal data.
SafeHeaders = []string{
HeaderVersion,
Expand All @@ -76,6 +84,9 @@ var (
HeaderChecksumAlgorithm,
HeaderChecksum,
HeaderUploadConcat,
HeaderXHTTPMethod,
HeaderXMethodOverride,
HeaderXOverrideMethod,
headers.Accept,
headers.AcceptCharset,
headers.AcceptEncoding,
Expand Down
Loading