Support for Rocq/Coq 9.0 #547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavierleroy
force-pushed
the
coq-9.0
branch
2 times, most recently
from
4c522af to
9a18217
Compare
Contributor
Author
|
CI action |
Contributor
Author
|
The docker situation was resolved (thanks @erikmd !), so the |
Works around a strange link-time inconsistency in some cases.
For compatibility with Rocq 9.0.
New Flocq require >= 8.15. Coq 9.0 is supported. Warn if Rocq is installed but not Coq.
Coq is now able to extract empty Coq types to empty OCaml types. This triggers a "unused-case" warning on pattern-matches involving the `BI_platform` constructor of argument `platform_builtin`, since the type `platform_builtin` is empty for RISC-V. This commit simply turns warning "unused-case" (56) off for extracted files. Note that "unused-case" warning is triggered by pattern-matching cases that are not reachable for reasons of types. It concerns mainly GADTs. The classic, non-type based "redundant-case" warning (11) is still active.
Rocq 9.0 wants `From Stdlib`, but Coq 8 understands `From Coq`. Changing `From Coq` to `From Stdlib` later will be easy.
Contributor
Author
|
All tests are positive, so let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for the Rocq prover version 9.0.
We still use the
coqc,coqtop, etc, command-line tools, relying on the Coq 9.0 compatibility layer.The main change is the explicit prefixing of imports from the standard library with
From Coq. At some later point this will becomeFrom Stdlib, but right now this would break compatibility with Coq 8.