Issue 2075 : Apply RGB on transpose matrices. #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ffer is C order or not, for now throw error Signed-off-by: Afsaneh Sheikhmiri <afsaneh.sheikhmiri@autodesk.com>
… test is still not passing Signed-off-by: Afsaneh Sheikhmiri <afsaneh.sheikhmiri@autodesk.com>
Asheikhm
force-pushed
the
Asheikh/dev-days/applyRGB_transpose
branch
from
c0c9a8a to
8883342
Compare
Asheikhm
force-pushed
the
Asheikh/dev-days/applyRGB_transpose
branch
2 times, most recently
from
5dc7b9e to
dedb64e
Compare
… are still contiguous Signed-off-by: Afsaneh Sheikhmiri <afsaneh.sheikhmiri@autodesk.com>
Asheikhm
force-pushed
the
Asheikh/dev-days/applyRGB_transpose
branch
from
dedb64e to
1cfb236
Compare
zachlewis
reviewed
Oct 27, 2025
zachlewis
approved these changes
Oct 28, 2025
doug-walker
approved these changes
Oct 28, 2025
Collaborator
doug-walker
left a comment
doug-walker
left a comment
There was a problem hiding this comment.
Great work @Asheikhm ! We will go ahead and merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix :
Added C-contiguity detection to the
applyRGBbuffer method inPyCPUProcessor.cpp. The fix checks if the input NumPy array is stored in row-major order by verifying that the memory strides match the expected C-contiguous layout. If the array isn't C-contiguous (like when someone passes a transposed column-major array without copying it), the method now throws a runtime error saying "applyRGB only supports C-contiguous (row-major) arrays". This prevents the color processor from silently processing data in the wrong order and forces users to ensure their arrays are properly laid out in memory before callingapplyRGB.