feat(exr): Write OpenEXR colorInteropID metadata based on oiio:ColorSpace #4967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
brechtvl
force-pushed
the
exr-write-interop-id
branch
3 times, most recently
from
10c758a to
8deb257
Compare
…pace If the colorspace exists and has an interop ID in an OCIO 2.5 config, use that. Otherwise check if the colorspace is equivalent to a known color interop ID. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
brechtvl
force-pushed
the
exr-write-interop-id
branch
from
8deb257 to
e0631dd
Compare
Contributor
Author
|
It's suspicous that an EXR related test is failing on Windows-2022, but not sure how it could be caused by the changes in this PR. |
Collaborator
|
The bleeding edge test is unrelated and I'm fixing it separately. Not sure about the windows one. I'm rerunning the failed tests now. A lot of glitchy stuff sometimes happens on the GHA runners, it's always worth trying again when something that has consistently passed for a long time spuriously fails. |
doug-walker
reviewed
Dec 15, 2025
24 tasks
Collaborator
|
Is this one ready to merge? |
Contributor
Author
|
Yes, all my PRs that are not marked as draft are ready. |
lgritz
approved these changes
Dec 19, 2025
lgritz
merged commit 693b09b
into
AcademySoftwareFoundation:main
54 of 57 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 22, 2025
…pace (AcademySoftwareFoundation#4967) If the colorspace exists and has an interop ID in an OCIO 2.5 config, use that. Otherwise check if the colorspace is equivalent to a known color interop ID. Tests were added. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 23, 2025
…pace (AcademySoftwareFoundation#4967) If the colorspace exists and has an interop ID in an OCIO 2.5 config, use that. Otherwise check if the colorspace is equivalent to a known color interop ID. Tests were added. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the colorspace exists and has an interop ID in an OCIO 2.5 config, use that.
Otherwise check if the colorspace is equivalent to a known color interop ID.
Tests
Tests were added.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.