feat(JXL): CICP read and write support for JPEG XL #4968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
The JPEG XL color encoding metadata only supports a subset of CICP. So for example srgb_p3d65_display and pq_rec2020_display are supported, but g26_xyzd65_display is not. Custom primaries, custom white point and arbitrary gamma could be used to support more, but I didn't implement that. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
24 tasks
zachlewis
approved these changes
Dec 22, 2025
Collaborator
zachlewis
left a comment
zachlewis
left a comment
There was a problem hiding this comment.
This is fantastic work, Brecht!
lgritz
merged commit ff89654
into
AcademySoftwareFoundation:main
28 of 30 checks passed
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 23, 2025
…undation#4968) The JPEG XL color encoding metadata only supports a subset of CICP. So for example `srgb_p3d65_display` and `pq_rec2020_display` are supported, but `g26_xyzd65_display` is not. Custom primaries, custom white point and arbitrary gamma could be used to support more, but I didn't implement that. Tests for read and write were added. Signed-off-by: Brecht Van Lommel <brecht@blender.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JPEG XL color encoding metadata only supports a subset of CICP. So for
example
srgb_p3d65_displayandpq_rec2020_displayare supported, butg26_xyzd65_displayis not.Custom primaries, custom white point and arbitrary gamma could be used to
support more, but I didn't implement that.
Tests
Tests for read and write were added.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.