fix(webp): Move write_complete_data() to close() for proper scanline … #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pmady
force-pushed
the
fix/webp-write-scanline-order
branch
from
bbe2145 to
eee49f9
Compare
Collaborator
|
The CI failures with messages about filling the disk are unrelated to this PR. If you rebase on the current main (or cherry pick #4974 into this PR), it will contain the fix and hopefully everything else will pass. |
…order support The WebP output plugin incorrectly assumed that scanlines would be written in sequential order, triggering the final write when y == height - 1. This violated the write_scanline API contract which allows scanlines to be written in any order (the plugin even advertises 'random_access' support). Changes: - Remove premature write_complete_data() call from write_scanline() - Move final encoding/writing to close() where it belongs - Move buffer cleanup to after write_complete_data() in close() The ioproxy_opened() check already guards against double-close, so no additional state tracking is needed. Fixes the issue where writing scanlines out of order would result in incomplete or corrupted WebP files. Signed-off-by: pmady <pavan4devops@gmail.com>
pmady
force-pushed
the
fix/webp-write-scanline-order
branch
from
eee49f9 to
9dad196
Compare
Contributor
Author
jessey-git
approved these changes
Dec 8, 2025
Contributor
jessey-git
left a comment
jessey-git
left a comment
There was a problem hiding this comment.
Looks alright to me now.
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Dec 17, 2025
…twareFoundation#4973) Move write_complete_data() to close() for proper scanline order support The WebP output plugin incorrectly assumed that scanlines would be written in sequential order, triggering the final write when y == height - 1. This violated the write_scanline API contract which allows scanlines to be written in any order (the plugin even advertises 'random_access' support). Changes: - Remove premature write_complete_data() call from write_scanline() - Move final encoding/writing to close() where it belongs - Add m_image_complete flag to track write state - Move buffer cleanup to after write_complete_data() in close() Fixes the issue where writing scanlines out of order would result in incomplete or corrupted WebP files. Signed-off-by: pmady <pavan4devops@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…order support
The WebP output plugin incorrectly assumed that scanlines would be written in sequential order, triggering the final write when y == height - 1. This violated the write_scanline API contract which allows scanlines to be written in any order (the plugin even advertises 'random_access' support).
Changes:
Fixes the issue where writing scanlines out of order would result in incomplete or corrupted WebP files.
Description
Tests
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.