Skip to content

Add pre-commit.ci to validate lint and format steps are all passing for CMake, C++ and Python files #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eloisebrosseau merged 4 commits into from
Jan 5, 2026
Merged

Add pre-commit.ci to validate lint and format steps are all passing for CMake, C++ and Python files #1038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2add407
Format all C++ files
eloisebrosseau Dec 22, 2025
7e369b5
Format all CMake files
eloisebrosseau Dec 22, 2025
3b7ec97
Remove Lint and Format step for ci.yml
eloisebrosseau Dec 22, 2025
25420b1
Disable pre-commit.ci auto-fixing PRs
eloisebrosseau Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,26 +35,6 @@ env:
WINDOWS_QT6_ARCHIVES: 'd3dcompiler_47 opengl32sw qtbase qtdeclarative qtsvg qttools qttranslations'

jobs:
lint-format:
name: "Lint and Format"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Install Python
uses: actions/setup-python@v5
with:
python-version: "3.11"
- name: Install dependencies
run: |
python3 -m pip install --upgrade pip
pip install ruff
- name: Run Ruff check
# Check if all the files are linted correctly
# Output errors as inline annotations
run: ruff check --output-format=github
- name: Run Ruff format
# Check if all the files are formatted correctly
run: ruff format --check
rocky-linux:
if : ${{ github.repository_owner == 'AcademySoftwareFoundation' }}
name: 'Rocky Linux ${{ matrix.rocky-version }} ${{ matrix.vfx-platform }}
Expand Down
3 changes: 3 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,6 @@ repos:
- id: clang-format
types_or: [c++, c]
exclude: '\.(m|mm)$'

ci:
autofix_prs: false
202 changes: 128 additions & 74 deletions cmake/defaults/CY2023.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,86 +1,140 @@
# CY2023 VFX Reference Platform versions of dependencies
# see https://vfxplatform.com/
# CY2023 VFX Reference Platform versions of dependencies see https://vfxplatform.com/

IF(RV_VFX_PLATFORM STREQUAL "CY2023")
# Year
SET(RV_VFX_CY_YEAR "2023")
SET(RV_VFX_CY2023 ON )
ADD_COMPILE_DEFINITIONS(RV_VFX_CY2023)
# Year
SET(RV_VFX_CY_YEAR
"2023"
)
SET(RV_VFX_CY2023
ON
)
ADD_COMPILE_DEFINITIONS(RV_VFX_CY2023)

# Boost
SET(RV_DEPS_BOOST_DOWNLOAD_HASH "077f074743ea7b0cb49c6ed43953ae95")
SET(RV_DEPS_BOOST_MAJOR_MINOR_VERSION "1_80")
SET(RV_DEPS_BOOST_VERSION "1.80.0")
# Boost
SET(RV_DEPS_BOOST_DOWNLOAD_HASH
"077f074743ea7b0cb49c6ed43953ae95"
)
SET(RV_DEPS_BOOST_MAJOR_MINOR_VERSION
"1_80"
)
SET(RV_DEPS_BOOST_VERSION
"1.80.0"
)

# Special case for XCode 15 on macOS
if(RV_TARGET_DARWIN)
execute_process(
COMMAND xcrun clang --version
OUTPUT_VARIABLE CLANG_FULL_VERSION_STRING
)
string(
REGEX
REPLACE ".*clang version ([0-9]+\\.[0-9]+).*" "\\1" CLANG_VERSION_STRING ${CLANG_FULL_VERSION_STRING}
)
if(CLANG_VERSION_STRING VERSION_GREATER_EQUAL 15.0)
message(STATUS "Clang version ${CLANG_VERSION_STRING} is not compatible with Boost 1.80, using Boost 1.81 instead. "
"Install XCode 14.3.1 if you absolutely want to use Boost version 1.80 as per VFX reference platform CY2023"
)
SET(RV_DEPS_BOOST_VERSION "1.81.0")
SET(RV_DEPS_BOOST_MAJOR_MINOR_VERSION "1_81")
SET(RV_DEPS_BOOST_DOWNLOAD_HASH "4bf02e84afb56dfdccd1e6aec9911f4b")
endif()
endif()
# Special case for XCode 15 on macOS
IF(RV_TARGET_DARWIN)
EXECUTE_PROCESS(
COMMAND xcrun clang --version
OUTPUT_VARIABLE CLANG_FULL_VERSION_STRING
)
STRING(
REGEX
REPLACE ".*clang version ([0-9]+\\.[0-9]+).*" "\\1" CLANG_VERSION_STRING ${CLANG_FULL_VERSION_STRING}
)
IF(CLANG_VERSION_STRING VERSION_GREATER_EQUAL 15.0)
MESSAGE(STATUS "Clang version ${CLANG_VERSION_STRING} is not compatible with Boost 1.80, using Boost 1.81 instead. "
"Install XCode 14.3.1 if you absolutely want to use Boost version 1.80 as per VFX reference platform CY2023"
)
SET(RV_DEPS_BOOST_VERSION
"1.81.0"
)
SET(RV_DEPS_BOOST_MAJOR_MINOR_VERSION
"1_81"
)
SET(RV_DEPS_BOOST_DOWNLOAD_HASH
"4bf02e84afb56dfdccd1e6aec9911f4b"
)
ENDIF()
ENDIF()

# Imath
# Can find the build version in OpenRV/_build/RV_DEPS_IMATH/install/lib/
SET(RV_DEPS_IMATH_VERSION "3.1.12")
SET(RV_DEPS_IMATH_DOWNLOAD_HASH "d4059140972da68a2b5a1287ebe5a653")
SET(RV_DEPS_IMATH_LIB_VER "29.11.0")
SET(RV_DEPS_IMATH_LIB_MAJOR "3_1")
# Imath Can find the build version in OpenRV/_build/RV_DEPS_IMATH/install/lib/
SET(RV_DEPS_IMATH_VERSION
"3.1.12"
)
SET(RV_DEPS_IMATH_DOWNLOAD_HASH
"d4059140972da68a2b5a1287ebe5a653"
)
SET(RV_DEPS_IMATH_LIB_VER
"29.11.0"
)
SET(RV_DEPS_IMATH_LIB_MAJOR
"3_1"
)

# NumPy
# NumPY for CY2023 is 1.23.x series but Pyside2 requires < 1.23
# So we comment this out and make_pyside.py hardcoded to use NumPy < 1.23
#SET(ENV{RV_DEPS_NUMPY_VERSION} "1.23.5")
# NumPy NumPY for CY2023 is 1.23.x series but Pyside2 requires < 1.23 So we comment this out and make_pyside.py hardcoded to use NumPy < 1.23
# SET(ENV{RV_DEPS_NUMPY_VERSION} "1.23.5")

# OCIO
# https://github.com/AcademySoftwareFoundation/OpenColorIO
SET(RV_DEPS_OCIO_VERSION "2.2.1")
SET(RV_DEPS_OCIO_VERSION_SHORT "2_2")
SET(RV_DEPS_OCIO_DOWNLOAD_HASH "d337d7cc890c6a04ad725556c2b7fb4c")
# OCIO https://github.com/AcademySoftwareFoundation/OpenColorIO
SET(RV_DEPS_OCIO_VERSION
"2.2.1"
)
SET(RV_DEPS_OCIO_VERSION_SHORT
"2_2"
)
SET(RV_DEPS_OCIO_DOWNLOAD_HASH
"d337d7cc890c6a04ad725556c2b7fb4c"
)

# OpenEXR
# https://github.com/AcademySoftwareFoundation/openexr/releases
SET(RV_DEPS_OPENEXR_VERSION "3.1.13")
SET(RV_DEPS_OPENEXR_DOWNLOAD_HASH "bbb385d52695502ea47303a2810a8bc1")
SET(RV_DEPS_OPENEXR_LIBNAME_SUFFIX "3_1")
SET(RV_DEPS_OPENEXR_LIB_VERSION_SUFFIX "30.13.1")
SET(RV_DEPS_OPENEXR_PATCH_NAME "openexr_${RV_DEPS_OPENEXR_VERSION}_invalid_to_black")
# OpenEXR https://github.com/AcademySoftwareFoundation/openexr/releases
SET(RV_DEPS_OPENEXR_VERSION
"3.1.13"
)
SET(RV_DEPS_OPENEXR_DOWNLOAD_HASH
"bbb385d52695502ea47303a2810a8bc1"
)
SET(RV_DEPS_OPENEXR_LIBNAME_SUFFIX
"3_1"
)
SET(RV_DEPS_OPENEXR_LIB_VERSION_SUFFIX
"30.13.1"
)
SET(RV_DEPS_OPENEXR_PATCH_NAME
"openexr_${RV_DEPS_OPENEXR_VERSION}_invalid_to_black"
)

# OpenSSL
# https://github.com/openssl/openssl
SET(RV_DEPS_OPENSSL_HASH "72f7ba7395f0f0652783ba1089aa0dcc")
SET(RV_DEPS_OPENSSL_VERSION "1.1.1u")
SET(RV_DEPS_OPENSSL_VERSION_DOT ".1.1")
SET(RV_DEPS_OPENSSL_VERSION_UNDERSCORE "1_1")
# OpenSSL https://github.com/openssl/openssl
SET(RV_DEPS_OPENSSL_HASH
"72f7ba7395f0f0652783ba1089aa0dcc"
)
SET(RV_DEPS_OPENSSL_VERSION
"1.1.1u"
)
SET(RV_DEPS_OPENSSL_VERSION_DOT
".1.1"
)
SET(RV_DEPS_OPENSSL_VERSION_UNDERSCORE
"1_1"
)

# PySide
SET(RV_DEPS_PYSIDE_TARGET "RV_DEPS_PYSIDE2")
SET(RV_DEPS_PYSIDE_VERSION "5.15.10")
SET(RV_DEPS_PYSIDE_DOWNLOAD_HASH "87841aaced763b6b52e9b549e31a493f")
# SET(RV_DEPS_PYSIDE_VERSION "5.15.18")
# SET(RV_DEPS_PYSIDE_DOWNLOAD_HASH "52aa32613f7a69ff46e38ed8a427eb38")
SET(RV_DEPS_PYSIDE_ARCHIVE_URL "https://mirrors.ocf.berkeley.edu/qt/official_releases/QtForPython/pyside2/PySide2-${RV_DEPS_PYSIDE_VERSION}-src/pyside-setup-opensource-src-${RV_DEPS_PYSIDE_VERSION}.zip")
# PySide
SET(RV_DEPS_PYSIDE_TARGET
"RV_DEPS_PYSIDE2"
)
SET(RV_DEPS_PYSIDE_VERSION
"5.15.10"
)
SET(RV_DEPS_PYSIDE_DOWNLOAD_HASH
"87841aaced763b6b52e9b549e31a493f"
)
# SET(RV_DEPS_PYSIDE_VERSION "5.15.18") SET(RV_DEPS_PYSIDE_DOWNLOAD_HASH "52aa32613f7a69ff46e38ed8a427eb38")
SET(RV_DEPS_PYSIDE_ARCHIVE_URL
"https://mirrors.ocf.berkeley.edu/qt/official_releases/QtForPython/pyside2/PySide2-${RV_DEPS_PYSIDE_VERSION}-src/pyside-setup-opensource-src-${RV_DEPS_PYSIDE_VERSION}.zip"
)

# Python
# https://www.python.org/downloads/source/
SET(RV_DEPS_PYTHON_VERSION "3.10.13")
SET(RV_DEPS_PYTHON_DOWNLOAD_HASH "21b32503f31386b37f0c42172dfe5637")
# SET(RV_DEPS_PYTHON_VERSION "3.10.18")
# SET(RV_DEPS_PYTHON_DOWNLOAD_HASH "e381359208e2bd0485169656b50ff24c")
# Python https://www.python.org/downloads/source/
SET(RV_DEPS_PYTHON_VERSION
"3.10.13"
)
SET(RV_DEPS_PYTHON_DOWNLOAD_HASH
"21b32503f31386b37f0c42172dfe5637"
)
# SET(RV_DEPS_PYTHON_VERSION "3.10.18") SET(RV_DEPS_PYTHON_DOWNLOAD_HASH "e381359208e2bd0485169656b50ff24c")

# Qt
SET(RV_DEPS_QT_VERSION "5.15.10")
SET(RV_DEPS_QT_MAJOR "5")
ENDIF()
# Qt
SET(RV_DEPS_QT_VERSION
"5.15.10"
)
SET(RV_DEPS_QT_MAJOR
"5"
)
ENDIF()
Loading
Loading