Skip to content

Conversation

@peter-targett
Copy link
Contributor

Summarize your change.

Extend Clip to allow effects and markers to be set, matching how Gap's can be initialized.

Reference associated tests.

Added basic C++ and Python tests.

Extend Clip to allow effects and markers to be set.

Signed-off-by: Peter Targett <petert@filmlight.ltd.uk>
Signed-off-by: Peter Targett <petert@filmlight.ltd.uk>
Signed-off-by: Peter Targett <petert@filmlight.ltd.uk>
Signed-off-by: Peter Targett <petert@filmlight.ltd.uk>
@jminor
Copy link
Collaborator

jminor commented Nov 11, 2024

Thanks for the update. Your change looks good to me. There's a build failure which I think is unrelated to your change. Let me see if we can find someone to help with that.

    File "/tmp/pip-build-env-hksa4rl4/overlay/lib/python3.9/site-packages/setuptools/_distutils/command/build_ext.py", line 502, in _build_extensions_serial
      self.build_extension(ext)
    File "<string>", line 70, in build_extension
    File "<string>", line 85, in build
    File "<string>", line 166, in cmake_preflight_check
  RuntimeError: CMake Error: Could not find CMAKE_ROOT !!!
  CMake has most likely not been installed correctly.
  Modules directory not found in
  /tmp/pip-build-env-hksa4rl4/overlay/share/cmake-3.31
  CMake Error: Error executing cmake::LoadCache(). Aborting.
  error: subprocess-exited-with-error

@peter-targett
Copy link
Contributor Author

This could be a separate pull request, I note the order of the arguments between gaps and clips could be more aligned.

@reinecke reinecke merged commit 5eafd40 into AcademySoftwareFoundation:main Dec 5, 2024
8 of 32 checks passed
@peter-targett peter-targett deleted the clip-effects-markers branch December 7, 2024 13:56
rameshbabuvfxtd pushed a commit to rameshbabuvfxtd/OpenTimelineIO that referenced this pull request Dec 10, 2024
…on#1808)

* Add effect and marker initialization to Clip

Extend Clip to allow effects and markers to be set.

Signed-off-by: Peter Targett <petert@filmlight.ltd.uk>

---------

Signed-off-by: Peter Targett <petert@filmlight.ltd.uk>
@ssteinbach ssteinbach added this to the Public Beta 18 milestone Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants