Drop Imath2 support and modernize Imath includes #1852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes. Additional details and impacted files@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
+ Coverage 84.11% 84.80% +0.69%
==========================================
Files 198 176 -22
Lines 22241 12745 -9496
Branches 4687 1181 -3506
==========================================
- Hits 18709 10809 -7900
+ Misses 2610 1758 -852
+ Partials 922 178 -744
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 123 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
As suggested by Imath devs, see AcademySoftwareFoundation/Imath#136 (comment) This is possible now that Imath 2 support was dropped Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
This will make it easier for downstream users Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
Signed-off-by: Julius Künzel <julius.kuenzel@kde.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your change.
As quickly discussed in the Slack channel...
OpenEXR developers recommend to use full namespace includes like
#include <Imath/ImathBox.h>, but we still use#include <ImathBox.h>.The support of OpenEXR/Imath 2 blocks changing the includes to full namespace. However Imath 3 has be released 4 years ago and OpenEXR/Imath 2 is no longer on the vfxplatform horizon so it seems appropriated to just remove support for it.