High framerate support #1854
Closed
High framerate support #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
time calculations
submodules
…ne (#2) Background In #1, changes were introduced to prevent DF/NDF from being inferred based on framerate alone. That change only applied to the "Sources" column of an EDL. Changes Extend "disable dropframe" capability to the reference timeline, in cases where a fractional-framterate-ndf clip is supplied to the exporter. Tests New external unit tests validate the issue, test steps described in previous PR can also be used.
* some debug logs for performance * remove debug noise * comprehensive optimization * more cleanup * one more fix
* Copy clip * Fix copy * Revert to functioning overwrite of clip
RikerG
force-pushed
the
high-framerate-support
branch
from
b2e6030 to
f41fa7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for framerates above 60 FPS.
RationalTime from_timecode and to_timecode functions modified to handle timecodes with 3 frames digits
Tests added for 120 FPS to confirm 3-digit framerates function as expected.