Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1855
Summarize your change.
This is a bug fix where V2d was getting serialized into two V2ds inside a Box2d. The problem was that there was no
write_valuefunction in the serialization for V2d (I guess it was assumed a V2d would always be inside a Box2d). Box2d has an implicit ctor taking a V2d, which implicitly converted the V2d to a Box2d to match on the Box2dwrite_valuemethod.Notes:
make testrequired me to runmake doc-model-updatewhich added some whitespace changes to otio-serialized-schema.mdmake lintchanged some whitespacing in the v2d testReference associated tests.
Two new tests added to
test_v2d.py