Skip to content

Conversation

@rogernelson
Copy link
Collaborator

@rogernelson rogernelson commented Mar 28, 2025

Fixes #1855

Summarize your change.

This is a bug fix where V2d was getting serialized into two V2ds inside a Box2d. The problem was that there was no write_value function in the serialization for V2d (I guess it was assumed a V2d would always be inside a Box2d). Box2d has an implicit ctor taking a V2d, which implicitly converted the V2d to a Box2d to match on the Box2d write_value method.

Notes:
make test required me to run make doc-model-update which added some whitespace changes to otio-serialized-schema.md
make lint changed some whitespacing in the v2d test

Reference associated tests.

Two new tests added to test_v2d.py

  • Check the schema is correct when serializing to json
  • Round trip serialization/deserialization ensures we get the original value back

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 28, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: rogernelson / name: Roger Nelson (afc83cd)

Signed-off-by: Roger Nelson <roger.nelson@autodesk.com>
@rogernelson rogernelson force-pushed the dev/nelsonr/v2d_serialization branch from c3a2515 to e3dfc88 Compare March 28, 2025 19:44
@rogernelson rogernelson changed the title Dev/nelsonr/v2d serialization V2d serialization fix Mar 28, 2025
Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changes to otio-serialized-schema.md might be a mistake (or at least, I want to double check that they aren't). Otherwise LGTM.

@ssteinbach ssteinbach added this to the Public Beta 18 milestone Mar 28, 2025
@rogernelson rogernelson force-pushed the dev/nelsonr/v2d_serialization branch from e3dfc88 to afc83cd Compare March 28, 2025 20:05
@ssteinbach ssteinbach merged commit 6f2c378 into AcademySoftwareFoundation:main Mar 29, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When calling track_with_expanded_transitions(), V2d objects are transformed into Box2d objects

3 participants