Skip to content

Conversation

@semagnum
Copy link
Contributor

@semagnum semagnum commented Aug 7, 2025

Fixes #1614

Summarize your change.

Fixes color deserialization so it works correctly. Add to documentation schema generator as well.

Reference associated tests.

Adds serialization test for coverage.

Signed-off-by: Spencer Magnusson <spencer.magnusson@dreamworks.com>
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.86%. Comparing base (c0e97b0) to head (0244567).
⚠️ Report is 61 commits behind head on main.

❌ Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1915      +/-   ##
==========================================
+ Coverage   84.11%   84.86%   +0.74%     
==========================================
  Files         198      181      -17     
  Lines       22241    13054    -9187     
  Branches     4687     1206    -3481     
==========================================
- Hits        18709    11078    -7631     
+ Misses       2610     1790     -820     
+ Partials      922      186     -736     
Flag Coverage Δ
py-unittests 84.86% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentimelineio/deserialization.cpp 64.05% <100.00%> (+11.94%) ⬆️
...timelineio/console/autogen_serialized_datamodel.py 79.10% <ø> (+0.58%) ⬆️
...-opentimelineio/opentimelineio/core/_core_utils.py 79.91% <ø> (-6.56%) ⬇️
tests/test_json_backend.py 93.93% <100.00%> (+0.49%) ⬆️

... and 133 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f662359...0244567. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jminor jminor merged commit 5abbdaf into AcademySoftwareFoundation:main Aug 11, 2025
47 checks passed
@semagnum semagnum deleted the color_hotfix branch August 11, 2025 17:30
@reinecke reinecke added this to the Public Beta 18 milestone Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per-clip and per-track color

4 participants