Skip to content

Conversation

@darbyjohnston
Copy link
Contributor

Fixes #1978

This PR removes the patch version from the OTIO namespace. As pointed out in #1978, patch versions shouldn't change the API, but we were making every release unique by including the patch number in the API itself.

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (4af7407) to head (63883e1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1979   +/-   ##
=======================================
  Coverage   85.13%   85.13%           
=======================================
  Files         181      181           
  Lines       12783    12783           
  Branches     1206     1206           
=======================================
  Hits        10883    10883           
  Misses       1717     1717           
  Partials      183      183           
Flag Coverage Δ
py-unittests 85.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/errorStatus.cpp 55.55% <ø> (ø)
src/opentime/errorStatus.h 100.00% <ø> (ø)
src/opentime/rationalTime.cpp 84.76% <ø> (ø)
src/opentime/rationalTime.h 95.83% <ø> (ø)
src/opentime/stringPrintf.h 57.14% <ø> (ø)
src/opentime/timeRange.h 98.38% <ø> (ø)
src/opentime/timeTransform.h 100.00% <ø> (ø)
src/opentimelineio/algo/editAlgorithm.cpp 0.00% <ø> (ø)
src/opentimelineio/anyDictionary.h 96.61% <ø> (ø)
src/opentimelineio/anyVector.h 90.32% <ø> (ø)
... and 55 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4af7407...63883e1. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@darbyjohnston
Copy link
Contributor Author

@reinecke Thinking about this after the meeting, I just wanted to call out that this PR does change the API by replacing OPENTIMELINEIO_VERSION with OPENTIMELINEIO_VERSION_NS.

So if people are using this in their C++ code:

namespace otio = opentimelineio::OPENTIMELINEIO_VERSION;

They will have to update it to this:

namespace otio = opentimelineio::OPENTIMELINEIO_VERSION_NS;

We provide the OTIO_NS macro as a shortcut, which hopefully most people are using, but not everyone might know about it. I wasn't sure how to fix this without making this change, so I'm open to any other ideas.

Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A problem, flaw, or broken functionality. opentime python-bindings time calculations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

library soversion is incorrectly used

2 participants