Krita output resize #2217
Krita output resize #2217
Conversation
* Added resize command for custom graph node useage
|
Updated and remade most of the resizing into the |
|
Would it be better if we do Run upscale -> Resizes canvas before applying the job or -> Resize Canvas after applying. I feel like having the resize happen before we apply it is better for the users end since they can see what it would look like if they dont like it just resize it manually? |
Not sure what you mean exactly? I think resizing for preview is not a good idea, because resize can be slow, and it's destructive (upscale and downscale back to original if you don't like does not restore original image). Resize on Apply (and possibly undo) is maybe not ideal, but can't think of anything better right now. |
* Removed old text output JSON * Dropped the dict handling * Updated ResizeCommand to a bool now
…a-ai-diffusion into custom-node-resize
Acly
left a comment
Acly
left a comment
There was a problem hiding this comment.
Yea this looks good, I just added a few more comments to simplify the code
.gitignore
Outdated
| lib | ||
| pyvenv.cfg | ||
| pyvenv.cfg | ||
| release_notes.md |
There was a problem hiding this comment.
please revert this change, it doesn't seem related
There was a problem hiding this comment.
My bad the gitignore was from my personal branch!
ai_diffusion/__init__.py
Outdated
| if importlib.util.find_spec("krita"): | ||
| from .extension import AIToolsExtension as AIToolsExtension | ||
| # The following imports depend on the code running inside Krita, so they cannot be imported in tests. | ||
| _krita_spec = importlib.util.find_spec("krita") |
There was a problem hiding this comment.
this change also doesn't seem related to the PR, and not sure why it's needed
|
Will do, some stuff from my experimenting branch leaked over for whatever reason. I'll get back to you once I'm free! |
|
There we go, reverted the odd changes before and used your suggestions to make the code just straight forward rather then using try/finally. If anything else was weird or got accidently changed on this branch let me know. |
2 participants
As stated in the #2216 fixed the confusing branches, still wrapping my head around Github entirely with PRs!
Updated the system to use the Krita output node now instead of a entirely different node. Sent a PR on the Tooling nodes to update the Krita output to include the "Width/Height" which are optional