cli: fix missing enumeration in switch #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o gguf * introduce `model_file` to read key-value data from gguf files * conditionally set `cwhn` flag based on gguf tensor data layout
migan: can now run in cwhn and whcn mode (but cwhn remains faster in all cases)
* convert weights on CPU after model load
* whcn is slower on both cpu or vulkan * whcn is more correct on vulkan, likely there is a bug in cwhn version of conv2d/deform
…meter * even though almost all tests use cwhn right now, whcn is the default in both ggml and pytorch.
* it's only available for WHCN layout for now, but faster than anything else * WHCN for model weights * WHCN for Vulkan * CWHN for CPU (converted at model load)
* probably CWHN version of birefnet is still somewhat broken, but since WHCN doesn't have the issue and is way faster there's not much incentive atm to fix
* times old -> new / new with coopmat2 * birefnet: 268ms -> 315ms / 243ms * birefnet-lite: 109ms -> 119 / 87ms * deform conv2d is a bit slower without coopmat2 support, but also requires much less vram, so still worth it
…memory was uninitialized
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.