Skip to content

Set requirements on how the authentication or signing order must be performed dynamically #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rfolkes merged 8 commits into from
Dec 4, 2024
Merged

Set requirements on how the authentication or signing order must be performed dynamically #475

rfolkes merged 8 commits into from
Dec 4, 2024

Conversation

@elinohlsson
Copy link
Contributor

@elinohlsson elinohlsson commented Nov 28, 2024 •
edited
Loading

This PR fixes #459 #476

High level overview of this PR:

  • Make it possible to register your own requirements resolver to set the requirements on how the authentication order must be performed (sent to the BankID API as part of the auth request) dynamically instead of statically during startup in Program.cs. In the same way as for user data (IBankIdAuthRequestUserDataResolver) and end user ip (IBankIdEndUserIpResolver).
  • Allow setting requirements (sent to the BankID API in the sign request) using BankIdSignProperties.
  • Update documentation with the above features.

Elin Fokine added 7 commits November 28, 2024 14:08
Allow setting personalNumber (which is part of the requirements sent …
7c3dd64 
…to the BankID API in the auth request) statically or dynamically using BankIdAuthUserData.
Allow setting personalNumber (which is part of the requirements sent …
69b5e3f 
…to the BankID API in the sign request) using BankIdSignProperties.
Added null check for requiredPersonalIdentityNumber.
50e6023
Add possibility to set requirements for mrtd and pincode as part of B…
4da5d36 
…ankIdSignProperties. If set it will override values in BankIdFlowOptions.
Add possibility to dynamically set auth requirements by overriding th…
8ad7861 
…e interface IBankIdAuthRequestRequirementsResolver.
Added tests for return url and risk.
dc51a7b
Added documentation about how to dynamically set requirements on how …
d37f085 
…the authentication or signature order must be performed.
@elinohlsson elinohlsson linked an issue Nov 29, 2024 that may be closed by this pull request
Add the possibility to set auth and sign requirements dynamically #476
Closed
@elinohlsson elinohlsson changed the title Feature/459 personalidentitynumber requirement Set requirements on how the authentication or signing order must be performed dynamically Nov 29, 2024
@Liteolika Liteolika marked this pull request as ready for review December 2, 2024 14:54
@rfolkes rfolkes merged commit 967a017 into main Dec 4, 2024
19 checks passed
@rfolkes rfolkes deleted the feature/459-personalidentitynumber-requirement branch December 4, 2024 21:58
@elinohlsson elinohlsson added this to the 11.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liteolika Liteolika Liteolika approved these changes

@rfolkes rfolkes Awaiting requested review from rfolkes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

@elinohlsson @Liteolika @rfolkes