Fix code scanning alert no. 124: Cross-site scripting #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
elinohlsson
approved these changes
Jan 16, 2025
elinohlsson
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/ActiveLogin/ActiveLogin.Authentication/security/code-scanning/124
To fix the cross-site scripting vulnerability, we need to sanitize the
returnUrlparameter before rendering it in the view. The best way to do this is to use theSystem.Net.WebUtility.HtmlEncodemethod to encode thereturnUrlvalue. This will ensure that any potentially malicious scripts in thereturnUrlare rendered as plain text and not executed by the browser.We will make the following changes:
returnUrlparameter in theAccountControllerbefore passing it to the view.Login.cshtmlview to use the sanitizedreturnUrl.Suggested fixes powered by Copilot Autofix. Review carefully before merging.