feature/478-state_storage: replace state cookie #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonnex
force-pushed
the
feature/478-state_storage
branch
from
ca043ce to
c072262
Compare
Contributor
Author
|
Should this PR wait for dotnet 9 PR to be merged? |
elinohlsson
reviewed
Feb 21, 2025
src/ActiveLogin.Authentication.BankId.AspNetCore/Auth/AuthenticationBuilderBankIdExtensions.cs
Outdated
Show resolved
Hide resolved
elinohlsson
reviewed
Feb 21, 2025
src/ActiveLogin.Authentication.BankId.AspNetCore/BankIdConstants.cs
Outdated
Show resolved
Hide resolved
elinohlsson
reviewed
Feb 21, 2025
src/ActiveLogin.Authentication.BankId.AspNetCore/Sign/ServiceCollectionBankIdExtensions.cs
Outdated
Show resolved
Hide resolved
elinohlsson
requested changes
Feb 21, 2025
Contributor
elinohlsson
left a comment
elinohlsson
left a comment
There was a problem hiding this comment.
Hard to review and verify that the it is working as expected. Needs to be tested. Only had a few comments of smaller changes.
test/ActiveLogin.Authentication.BankId.AspNetCore.Test/BankId_Ui_Tests_Base.cs
Outdated
Show resolved
Hide resolved
test/ActiveLogin.Authentication.BankId.AspNetCore.Test/BankId_Ui_Tests_Base.cs
Outdated
Show resolved
Hide resolved
Contributor
|
@Zonnex also add to documentation how to create your own implementation of IStateStorage. |
Zonnex
force-pushed
the
feature/478-state_storage
branch
2 times, most recently
from
c42196e to
aa5a85f
Compare
Contributor
Author
|
This feature needs more work. The proposed solution is too simple, and should perhaps support a distributed environment out of the box. A new implementation should perhaps use HybridCache or IDistributedCache. I will convert this to draft to avoid mistakes by merging in work that isn't sufficient |
Zonnex
force-pushed
the
feature/478-state_storage
branch
2 times, most recently
from
d9c066b to
f612b4e
Compare
Zonnex
force-pushed
the
feature/478-state_storage
branch
from
0e59cb7 to
fcb4c2c
Compare
Zonnex
force-pushed
the
feature/478-state_storage
branch
3 times, most recently
from
85d4bc9 to
2557a87
Compare
Zonnex
force-pushed
the
feature/478-state_storage
branch
from
2557a87 to
786f80b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #478.
High level overview of this PR: