Feature/479 nonce #500
Closed
Feature/479 nonce #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zonnex
force-pushed
the
feature/479-nonce
branch
2 times, most recently
from
83f8b9c to
495cc35
Compare
Zonnex
force-pushed
the
feature/479-nonce
branch
from
495cc35 to
cfb0110
Compare
Contributor
|
In many scenarios (depending on device, OS, etc.), Active Login deliberately clears the returnUrl value and replaces it with an empty string. This is required to make the flow work, the BankID app closes, and the user returns to the application in the background. Because of this behavior, letting Active Login attach a nonce to the returnUrl isn’t straightforward. I think we need to handle this another way. Will close this PR for now and open a new issue for potential improvements in this area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds nonce and nonce-validation.
Created as draft for review. Piggy-backing on state-storage feature because we use IMemoryCache here as well.