Skip to content

Feature/504 device data cookie #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
elinohlsson merged 4 commits into from
Aug 29, 2025
Merged

Feature/504 device data cookie #510

elinohlsson merged 4 commits into from
Aug 29, 2025

Conversation

@elinohlsson
Copy link
Contributor

@elinohlsson elinohlsson commented Aug 22, 2025 •
edited
Loading

This PR fixes #504

High level overview of this PR:

  • Improved documentation about risk indication.
  • Clarified documentation about cookies, data protection and the need to configure a persisted key store in some scenarios.
  • Added an important note in the release notes about cookies introduced in version 10.1, which have been shown to cause problems for some users.
  • Clarified documentation about Device Data (app and web parameters) and removed incorrect references to non-existing classes and methods.

@elinohlsson elinohlsson requested a review from Liteolika August 22, 2025 14:12
@elinohlsson elinohlsson added this to the Next release milestone Aug 22, 2025
Liteolika
Liteolika reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@Liteolika Liteolika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I made a comment on the documentation regarding the BankIdDefaultEndUserAppDeviceDataResolver that needs to be fixed.

@elinohlsson elinohlsson requested a review from Liteolika August 29, 2025 09:14
@elinohlsson elinohlsson merged commit 969d25c into main Aug 29, 2025
19 checks passed
@elinohlsson elinohlsson deleted the feature/504-device-data-cookie branch August 29, 2025 11:06
@elinohlsson elinohlsson modified the milestone: Next release Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liteolika Liteolika Liteolika approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

11.1.0

Development

Successfully merging this pull request may close these issues.

After upgrading from v9 to v10.1.0, auth and sign flows fail unless the old __ActiveLogin.BankIdDeviceData cookie is cleared

3 participants

@elinohlsson @Liteolika