-
Notifications
You must be signed in to change notification settings - Fork 145
[capital] Code generation: update services and models #1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the capital service models, primarily focusing on refactoring the Amount and Counterparty entities. The Amount model's Javadoc has been clarified for better understanding. The Counterparty model has been renamed to GrantCounterparty, and a new GrantInfoCounterparty model has been introduced, likely to provide more specific counterparty details for grant information. The Grant and GrantInfo models have been adjusted to reflect these changes, including the removal of direct Amount fields and the adoption of the new counterparty types. Additionally, the Status model has been updated to remove Underwriting and Assessed from its CodeEnum, streamlining the possible grant statuses. All changes appear to be consistent with an API update and are implemented correctly, maintaining code quality and clarity.
|
Since one class was renamed, tests must be updated |
212d3de to
0a563cb
Compare
0a563cb to
4e66d49
Compare
This PR contains the automated changes for the
capitalservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.