Fix sse streaming function call error with agentops#1207
Draft
Fix sse streaming function call error with agentops#1207
Conversation
Co-authored-by: alex <alex@agentops.ai>
|
Cursor Agent can help with this pull request. Just |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
This pull request has been automatically marked as stale because it has not had any activity in the last 14 days. If no updates are made within 7 days, this PR will be automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📥 Pull Request
📘 Description
Fixes a
TypeError(can only concatenate str (not "NoneType") to str) that occurred when AgentOps instrumented Google ADKrun_asynccalls withstreaming_mode="sse"andresponse_modalities=["TEXT"], and the LLM response included non-text parts (e.g., function calls). The issue was caused byNonevalues from these non-text parts being passed to string concatenation. The fix adds defensive checks to ensure only valid text is processed.🧪 Testing
A new example (
agentops/examples/google_adk/sse_text_function_call.py) was created to reproduce the reported scenario. Manual testing was performed by running this example, confirming that theTypeErrorno longer occurs and that streaming events (including function calls and responses) are processed correctly. Automated tests were not run in the current environment.