fix: skip wrapping missing google.adk telemetry functions#1278
Open
themavik wants to merge 1 commit intoAgentOps-AI:mainfrom
Open
fix: skip wrapping missing google.adk telemetry functions#1278themavik wants to merge 1 commit intoAgentOps-AI:mainfrom
themavik wants to merge 1 commit intoAgentOps-AI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1257
When using AgentOps with
google-adk>=1.5.0, users see a confusing warning:This happens because
trace_tool_responsewas removed/renamed in newer versions of google-adk, but_patch_module_functiontreats all failures the same (warning level).Fix
Added a
hasattr()check in_patch_module_functionbefore attempting to wrap. If the function doesn't exist in the current module version, it logs atdebuglevel and returns early, avoiding the confusing warning.