Skip to content

Add safe JSON serializa for Agents SDK inputs and outputs #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dwij1704 wants to merge 4 commits into from
Closed

Add safe JSON serializa for Agents SDK inputs and outputs #842

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
03bb7fd
Add safe JSON serializa for Agents SDK inputs and outputs
Dwij1704 Mar 14, 2025
e9ece2b
Refactor serialization in Agents SDK to use safe_serialize function f…
Dwij1704 Mar 14, 2025
cda53c5
Implement serialize_if_complex function for improved object serializa…
Dwij1704 Mar 14, 2025
540d0c8
Refactor serialization in Agents SDK to remove serialize_if_complex a…
Dwij1704 Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions third_party/opentelemetry/instrumentation/agents/agentops_agents_instrumentor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
SpanAttributes,
Meters,
)
from agentops.helpers.serialization import safe_serialize

# Agents SDK imports
from agents.tracing.processor_interface import TracingProcessor as AgentsTracingProcessor
Expand All @@ -51,7 +52,6 @@
# Keep track of active streaming operations to prevent premature shutdown
_active_streaming_operations = set()


def safe_execute(func):
"""Decorator to safely execute a function and log any exceptions."""

Expand Down Expand Up @@ -182,10 +182,10 @@ def _export_span(self, span: AgentsSpan[Any]) -> None:
attributes[AgentAttributes.AGENT_NAME] = span_data.name

if hasattr(span_data, "input") and span_data.input:
attributes[SpanAttributes.LLM_PROMPTS] = str(span_data.input)[:1000] # Truncate long inputs
attributes[SpanAttributes.LLM_PROMPTS] = safe_serialize(span_data.input)

if hasattr(span_data, "output") and span_data.output:
attributes[SpanAttributes.LLM_COMPLETIONS] = str(span_data.output)[:1000] # Truncate long outputs
attributes[SpanAttributes.LLM_COMPLETIONS] = safe_serialize(span_data.output)

# Extract model information - check for GenerationSpanData specifically
if span_type == "Generation" and hasattr(span_data, "model") and span_data.model:
Expand Down Expand Up @@ -411,7 +411,7 @@ def instrumented_run_streamed(
attributes = {
"span.kind": WorkflowAttributes.WORKFLOW_STEP,
"agent.name": starting_agent.name,
WorkflowAttributes.WORKFLOW_INPUT: str(input)[:1000],
WorkflowAttributes.WORKFLOW_INPUT: safe_serialize(input),
WorkflowAttributes.MAX_TURNS: max_turns,
"service.name": "agentops.agents",
WorkflowAttributes.WORKFLOW_TYPE: "agents.run_streamed",
Expand Down Expand Up @@ -447,7 +447,7 @@ def instrumented_run_streamed(
instruction_type = "unknown"
if isinstance(starting_agent.instructions, str):
instruction_type = "string"
span.set_attribute("agent.instructions", starting_agent.instructions[:1000])
span.set_attribute("agent.instructions", starting_agent.instructions)
elif callable(starting_agent.instructions):
instruction_type = "function"
# Store the function name or representation
Expand All @@ -456,7 +456,7 @@ def instrumented_run_streamed(
)
span.set_attribute("agent.instruction_function", func_name)
else:
span.set_attribute("agent.instructions", str(starting_agent.instructions)[:1000])
span.set_attribute("agent.instructions", str(starting_agent.instructions))

span.set_attribute("agent.instruction_type", instruction_type)

Expand Down Expand Up @@ -609,7 +609,7 @@ async def instrumented_stream_events():
# Add result attributes to the span
if hasattr(result, "final_output"):
usage_span.set_attribute(
WorkflowAttributes.FINAL_OUTPUT, str(result.final_output)[:1000]
WorkflowAttributes.FINAL_OUTPUT, safe_serialize(result.final_output)
)

# Extract model and response information
Expand Down Expand Up @@ -866,7 +866,7 @@ async def instrumented_method(
attributes = {
"span.kind": WorkflowAttributes.WORKFLOW_STEP,
"agent.name": starting_agent.name,
WorkflowAttributes.WORKFLOW_INPUT: str(input)[:1000],
WorkflowAttributes.WORKFLOW_INPUT: safe_serialize(input),
WorkflowAttributes.MAX_TURNS: max_turns,
"service.name": "agentops.agents",
WorkflowAttributes.WORKFLOW_TYPE: f"agents.{_method_name}",
Expand Down Expand Up @@ -902,7 +902,7 @@ async def instrumented_method(
instruction_type = "unknown"
if isinstance(starting_agent.instructions, str):
instruction_type = "string"
span.set_attribute("agent.instructions", starting_agent.instructions[:1000])
span.set_attribute("agent.instructions", starting_agent.instructions)
elif callable(starting_agent.instructions):
instruction_type = "function"
# Store the function name or representation
Expand All @@ -911,7 +911,7 @@ async def instrumented_method(
)
span.set_attribute("agent.instruction_function", func_name)
else:
span.set_attribute("agent.instructions", str(starting_agent.instructions)[:1000])
span.set_attribute("agent.instructions", str(starting_agent.instructions))

span.set_attribute("agent.instruction_type", instruction_type)

Expand Down Expand Up @@ -971,7 +971,7 @@ async def instrumented_method(

# Add result attributes to the span
if hasattr(result, "final_output"):
span.set_attribute(WorkflowAttributes.FINAL_OUTPUT, str(result.final_output)[:1000])
span.set_attribute(WorkflowAttributes.FINAL_OUTPUT, safe_serialize(result.final_output))

# Extract model and response information
response_id = None
Expand Down Expand Up @@ -1136,7 +1136,7 @@ def instrumented_method(
attributes = {
"span.kind": WorkflowAttributes.WORKFLOW_STEP,
"agent.name": starting_agent.name,
WorkflowAttributes.WORKFLOW_INPUT: str(input)[:1000],
WorkflowAttributes.WORKFLOW_INPUT: safe_serialize(input),
WorkflowAttributes.MAX_TURNS: max_turns,
"service.name": "agentops.agents",
WorkflowAttributes.WORKFLOW_TYPE: f"agents.{_method_name}",
Expand Down Expand Up @@ -1172,7 +1172,7 @@ def instrumented_method(
instruction_type = "unknown"
if isinstance(starting_agent.instructions, str):
instruction_type = "string"
span.set_attribute("agent.instructions", starting_agent.instructions[:1000])
span.set_attribute("agent.instructions", starting_agent.instructions)
elif callable(starting_agent.instructions):
instruction_type = "function"
# Store the function name or representation
Expand All @@ -1181,7 +1181,7 @@ def instrumented_method(
)
span.set_attribute("agent.instruction_function", func_name)
else:
span.set_attribute("agent.instructions", str(starting_agent.instructions)[:1000])
span.set_attribute("agent.instructions", str(starting_agent.instructions))

span.set_attribute("agent.instruction_type", instruction_type)

Expand Down Expand Up @@ -1241,7 +1241,7 @@ def instrumented_method(

# Add result attributes to the span
if hasattr(result, "final_output"):
span.set_attribute(WorkflowAttributes.FINAL_OUTPUT, str(result.final_output)[:1000])
span.set_attribute(WorkflowAttributes.FINAL_OUTPUT, safe_serialize(result.final_output))

# Extract model and response information
response_id = None
Expand Down
Loading