Conversation
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Helpful! Can you also update the documentation to tell users how to provide this info? Does this mean we could do |
|
I would say we won't be able to do |
Dwij1704
left a comment
There was a problem hiding this comment.
@fenilfaldu You might have misunderstood this, the issue is that we don't set tags that we get from init in case of crewai, We need a mechanism to set list of tags in span attributes of root span (crewai.workflow etc). This can be done by setting it in the crewai instrumentor itself where the root span is first started.
The naming modifications you did is redundant for this issue, pick up #988 after you are done with this.
I recommend closing this PR and raising a new one that only has changes related to tags in crewai and another PR with changes regarding setting span name for root spans that cover both sessions span and crewai specific root span types.
|
Got it! closing this pr and raised the new one :) |
📥 Pull Request
📘 Description
Added support for customizing task span names using default tags and updated task span creation to use tag-based naming when available also maintained backward compatibility with default "crewai.task" name if no default-tags were passed while Initialization.
🧪 Testing
Tested the
mardown_validator.ipynbrunbook.