Merged
Conversation
This reverts commit 63fdd7f.
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the changes introduced in commit 63fdd7f because commit #987 already fixes the original duplicate LLM call issue.
- Reverts provider-specific instrumentation logic for LLM calls.
- Simplifies exception handling and logging within the span context.
- Restores previous behavior regarding trace creation.
Comments suppressed due to low confidence (2)
agentops/instrumentation/crewai/instrumentation.py:412
- With the reversion removing the provider instrumentation logic, please verify that the simplified approach maintains correct behavior across all LLM providers.
llm = instance.model if hasattr(instance, "model") else "llm"
agentops/instrumentation/crewai/instrumentation.py:461
- [nitpick] The change to 'ex' improves clarity; ensure that similar exception handling in other parts of the codebase follows a consistent naming pattern.
except Exception as ex:
Dwij1704
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 63fdd7f.
Because #987 fixes the original issue.