Skip to content

25.8.14 Backport of #86633 - Add support for user names in config containing a dot #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zvonand wants to merge 2 commits into
base: releases/25.8.14
Choose a base branch
from
+6 −2
Open

25.8.14 Backport of #86633 - Add support for user names in config containing a dot #1308

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80eeeca
Merge pull request #86633 from mkmkme/mkmkme/name-dots
azat Sep 9, 2025
dabf9d5
Merge branch 'releases/25.8.14' into backports/25.8.14/86633
zvonand Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Access/UsersConfigAccessStorage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,16 +114,20 @@ namespace

UserPtr parseUser(
const Poco::Util::AbstractConfiguration & config,
const String & user_name,
String user_name,
const std::unordered_set<UUID> & allowed_profile_ids,
const std::unordered_set<UUID> & allowed_role_ids,
bool allow_no_password,
bool allow_plaintext_password)
{
const bool validate = true;
auto user = std::make_shared<User>();
user->setName(user_name);
String user_config = "users." + user_name;

/// If the user name contains a dot, it is escaped with a backslash when parsed from the config file.
/// We need to remove the backslash to get the correct user name.
Poco::replaceInPlace(user_name, "\\.", ".");
user->setName(user_name);
bool has_no_password = config.has(user_config + ".no_password");
bool has_password_plaintext = config.has(user_config + ".password");
bool has_password_sha256_hex = config.has(user_config + ".password_sha256_hex");
Expand Down
Loading