Skip to content

25.8.14 Stable backport of #90243: Fix crash in StorageDistributed when parsing malformed shard directory names #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zvonand wants to merge 1 commit into
base: releases/25.8.14
Choose a base branch
from
Open

25.8.14 Stable backport of #90243: Fix crash in StorageDistributed when parsing malformed shard directory names #1310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Storages/StorageDistributed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1690,9 +1690,11 @@ Cluster::Addresses StorageDistributed::parseAddresses(const std::string & name)
continue;
}

if (address.replica_index > replicas)
if (address.replica_index == 0 || address.replica_index > replicas)
{
LOG_ERROR(log, "No shard with replica_index={} ({})", address.replica_index, name);
LOG_ERROR(log, "Invalid replica_index={} for directory '{}' (cluster has {} replicas for shard {}). "
"Expected directory format: 'shardN_replicaM' or 'shardN_all_replicas'",
address.replica_index, dirname, replicas, address.shard_index);
continue;
}

Expand Down
Loading