impl #1324
impl #1324
Conversation
|
I will add more details tomorrow |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed2bb31baa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| auto defaults_dag = evaluateMissingDefaults( | ||
| *current_header, | ||
| all_columns, | ||
| metadata_snapshot->getColumns(), |
There was a problem hiding this comment.
This step builds defaults/reordering from all_columns, which includes ALIAS columns from the source. The export sink’s header comes from the destination’s getSampleBlock() (physical-only; see StorageInMemoryMetadata::getSampleBlock()), so if the destination table also defines an ALIAS column (same schema as source), the pipeline will output that alias column and StorageObjectStorageSink::consume() will throw because Block::cloneWithColumns requires the column count to match the physical header. This means EXPORT PART fails for tables that include aliases on the destination. Consider filtering to the destination’s physical columns (or using its sample block) when building the output DAG.
Useful? React with 👍 / 👎.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: