fix: building vignettes and testthat#65
Open
novica wants to merge 2 commits intoAnotherSamWilson:masterfrom
Open
fix: building vignettes and testthat#65novica wants to merge 2 commits intoAnotherSamWilson:masterfrom
novica wants to merge 2 commits intoAnotherSamWilson:masterfrom
Conversation
Author
|
Seems this is related to #61 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, it seems the issue is related to
xgboostbeing updated and some arguments having their name changed. I don't know the details, but copilot was able to fix the issues and now devtools::test() and devtools::check() pass on my computer (windows 11, r 4.5.2). It would be good if someone who knowsxgboostand related to verify this, of course.Also,
usethiscan help set up a r cmd check gh-action. I think that would be useful.