add optional client arg to HTMX for persistent tests #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/824 |
johnowhitaker
commented
Jan 29, 2026
| [tool.nbdev] | ||
| jupyter_hooks = true | ||
| custom_sidebar = false | ||
| lib_path = "fasthtml" |
Contributor
Author
There was a problem hiding this comment.
Otherwise nbdev-export creates a python_fasthtml directory based on name = "python-fasthtml".
johnowhitaker
commented
Jan 29, 2026
| res = path | ||
| app.get(route)(lambda: res) | ||
| page = TestClient(app).get(route).text | ||
| cli = client if client is not None else TestClient(app) |
Contributor
Author
There was a problem hiding this comment.
This is the change: can now use an existing client if provided
Contributor
Author
|
@jph00 :) |
Contributor
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing FastHTML apps with authentication in notebooks, the default HTMX function creates a fresh TestClient for each render. This means session cookies (like auth) don't persist, making it difficult to preview authenticated content. This change allows one to pass in an existing TestClient to use, allowing for preview of things that require session state.
Worked example: https://share.solve.it.com/d/d19bed2aa88ed7476a03b821a29caef7